On Thu, May 16, 2024, 05:13 Noah Moroze <noahmor...@gmail.com> wrote:
> Hi, > > I maintain tclint <https://github.com/nmoroze/tclint>, an open-source > linter/static analysis tool for Tcl. Someone pointed to OpenOCD > <https://github.com/nmoroze/tclint/issues/34> as something to run tclint > against, which led me to find a few syntax errors lurking in OpenOCD's Tcl > code. > > I've submitted several small patches to address these issues based on my > inferred intent of the original code. Beyond the patches, I wanted to send > this note to explain how I came across these errors. I figure tclint could > be useful in developers' workflows and possibly even as a CI check to > ensure issues like these don't sneak in in the future. > > Here's a quick way to reproduce my results: > > ``` > python3 -m pip install tclint # or use `pipx` to avoid polluting your > Python env > tclint openocd/ | grep "syntax error" > ``` > > Thanks, > Noah > Hi Noah, Thanks for the tool and for the patches you have pushed. I just gave a quick look at them, and looks correct. Today we do not have any automatic TCL check so your tool looks like a good candidate. I plan to use it for the next reviews. Adding it to our ACI... it would be good, but I want to be sure we don't have false positives. Regards Antonio >
