On Sun, May 19, 2024, 17:34 Jan Cumps <jcu...@gmail.com> wrote: > I submitted GERRIT request 8287: > https://review.openocd.org/c/openocd/+/8287?forceReload=true > > Validation fails, with style error: > > checking patch ... > ERROR:SPACING: space required after that ',' (ctx:VxV) > #23: FILE: src/flash/nor/spi.c:187: > + FLASH_ID("pu p32q32", 0x03, 0xeb, 0x02, 0xd8, 0xc7, 0x00156085, > 0x100, 0x10000, 0x4000000), >
Hi, thanks for your patch. In your patch, between '0x10000,' and '0x400000),' there is a special character that looks like a whitespace, but it's something else. The tool hexdump reports a utf-8 character 0xc2a0. > I used the same formatting rules and spaces a s the other lines in > that source file: > TAB in the beginning > spaces in the middle to adjust the outline > a space after that ',' > > This is my first patch attempt. Do I have to change the code? > Yes, you should send a new version of the patch. Since the change is quite trivial, you can try to use the function EDIT in the website review.openocd.org by sign-in, click in your patch on the file spi.c and click EDIT on top-right in the page. Edit and then save and publish Regards Antonio >
