This is an automated email from Gerrit.

"zapb <d...@zapb.de>" just uploaded a new patch set to Gerrit, which you can 
find at https://review.openocd.org/c/openocd/+/8380

-- gerrit

commit 1f81ae7fd516d7ea6728bfe64040531ef485f9b2
Author: Marc Schink <d...@zapb.de>
Date:   Tue Jul 2 17:12:46 2024 +0200

    Deprecate jimtcl Git submodule
    
    jimtcl was integrated as Git submodule for convenience and probably also
    because packages were not widely available at the time. Today, jimtcl is
    available in many popular package repositories [1] and the integration
    as Git submodule adds unnecessary complexity to the OpenOCD build
    process. For details, see the discussion on the mailing list in [2].
    
    Disable the jimtcl Git submodule by default and announce it as
    deprecated feature that will be removed in the next release. This gives
    package maintainers time to adapt to the change and, if necessary,
    build a package for jimtcl.
    
    [1] https://repology.org/project/jimtcl/versions
    [2] https://sourceforge.net/p/openocd/mailman/message/58786630/
    
    Change-Id: I07930ac07f7d7a6317c08b21dc118f4f128b331c
    Signed-off-by: Marc Schink <d...@zapb.de>

diff --git a/configure.ac b/configure.ac
index becc531b0d..6b5e90f1f0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -372,8 +372,8 @@ AS_CASE([$host_os],
 ])
 
 AC_ARG_ENABLE([internal-jimtcl],
-  AS_HELP_STRING([--disable-internal-jimtcl], [Disable building internal 
jimtcl]),
-  [use_internal_jimtcl=$enableval], [use_internal_jimtcl=yes])
+  AS_HELP_STRING([--enable-internal-jimtcl], [Enable building internal jimtcl 
(deprecated)]),
+  [use_internal_jimtcl=$enableval], [use_internal_jimtcl=no])
 
 AC_ARG_ENABLE([jimtcl-maintainer],
   AS_HELP_STRING([--enable-jimtcl-maintainer], [Enable maintainer mode when 
building internal jimtcl]),
@@ -848,6 +848,10 @@ AS_IF([test "x$enable_jlink" != "xno"], [
   ]])
 )
 
+AS_IF([test "x$use_internal_jimtcl" = "xyes"], [
+  AC_MSG_WARN([Using the internal jimtcl is deprecated and will not be 
possible in the future.])
+])
+
 echo
 echo
 echo OpenOCD configuration summary

-- 

Reply via email to