[PATCH]: 8541f717df jtag: Use 'unsigned int' for 'abs_chain_position'

[gerrit]

This is an automated email from Gerrit.

"zapb <d...@zapb.de>" just uploaded a new patch set to Gerrit, which you can 
find at https://review.openocd.org/c/openocd/+/8402

-- gerrit

commit 8541f717df1546c763b369635a05cb5111727a37
Author: Marc Schink <d...@zapb.de>
Date:   Wed Jul 17 16:48:14 2024 +0200

    jtag: Use 'unsigned int' for 'abs_chain_position'
    
    Change-Id: I1ac0a6a86f820b051619aa132754a69b8f8e0ab9
    Signed-off-by: Marc Schink <d...@zapb.de>

diff --git a/src/jtag/core.c b/src/jtag/core.c
index c8f20b73c6..939199462e 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -212,7 +212,7 @@ unsigned jtag_tap_count_enabled(void)
 /** Append a new TAP to the chain of all taps. */
 static void jtag_tap_add(struct jtag_tap *t)
 {
-       unsigned jtag_num_taps = 0;
+       unsigned int jtag_num_taps = 0;
 
        struct jtag_tap **tap = &__jtag_all_taps;
        while (*tap) {
@@ -1471,7 +1471,7 @@ void jtag_tap_init(struct jtag_tap *tap)
        jtag_register_event_callback(&jtag_reset_callback, tap);
        jtag_tap_add(tap);
 
-       LOG_DEBUG("Created Tap: %s @ abs position %d, "
+       LOG_DEBUG("Created Tap: %s @ abs position %u, "
                        "irlen %d, capture: 0x%x mask: 0x%x", tap->dotted_name,
                        tap->abs_chain_position, tap->ir_length,
                        (unsigned) tap->ir_capture_value,
diff --git a/src/jtag/jtag.h b/src/jtag/jtag.h
index 470ae18334..46ab584d92 100644
--- a/src/jtag/jtag.h
+++ b/src/jtag/jtag.h
@@ -102,7 +102,7 @@ struct jtag_tap {
        char *chip;
        char *tapname;
        char *dotted_name;
-       int abs_chain_position;
+       unsigned int abs_chain_position;
        /** Is this TAP disabled after JTAG reset? */
        bool disabled_after_reset;
        /** Is this TAP currently enabled? */
@@ -150,7 +150,7 @@ struct jtag_tap *jtag_all_taps(void);
 const char *jtag_tap_name(const struct jtag_tap *tap);
 struct jtag_tap *jtag_tap_by_string(const char *dotted_name);
 struct jtag_tap *jtag_tap_by_jim_obj(Jim_Interp *interp, Jim_Obj *obj);
-struct jtag_tap *jtag_tap_by_position(unsigned abs_position);
+struct jtag_tap *jtag_tap_by_position(unsigned int abs_position);
 struct jtag_tap *jtag_tap_next_enabled(struct jtag_tap *p);
 unsigned jtag_tap_count_enabled(void);
 unsigned jtag_tap_count(void);
diff --git a/src/target/riscv/riscv-013.c b/src/target/riscv/riscv-013.c
index 2f4a8fe2e6..0aa82031cd 100644
--- a/src/target/riscv/riscv-013.c
+++ b/src/target/riscv/riscv-013.c
@@ -132,7 +132,7 @@ typedef enum {
 
 typedef struct {
        struct list_head list;
-       int abs_chain_position;
+       unsigned int abs_chain_position;
 
        /* The number of harts connected to this DM. */
        int hart_count;
@@ -236,7 +236,7 @@ static dm013_info_t *get_dm(struct target *target)
        if (info->dm)
                return info->dm;
 
-       int abs_chain_position = target->tap->abs_chain_position;
+       unsigned int abs_chain_position = target->tap->abs_chain_position;
 
        dm013_info_t *entry;
        dm013_info_t *dm = NULL;

--