[PATCH]: 3c24d340c9 binarybuffer: add asserts for the number of requested bits for get/set functions

[gerrit]

This is an automated email from Gerrit.

"Anatoly P <anatoly.parshint...@syntacore.com>" just uploaded a new patch set 
to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8427

-- gerrit

commit 3c24d340c93bf88e436b1740bb5863ae14f9690e
Author: Parshintsev Anatoly <anatoly.parshint...@syntacore.com>
Date:   Sat Aug 3 22:10:57 2024 +0300

    binarybuffer: add asserts for the number of requested bits for get/set 
functions
    
    Change-Id: Ieca5b4e690c9713ad60dc9d8c223c2d64822e2f5
    Signed-off-by: Parshintsev Anatoly <anatoly.parshint...@syntacore.com>

diff --git a/src/helper/binarybuffer.h b/src/helper/binarybuffer.h
index 441374330e..3408506240 100644
--- a/src/helper/binarybuffer.h
+++ b/src/helper/binarybuffer.h
@@ -34,6 +34,7 @@
 static inline void buf_set_u32(uint8_t *_buffer,
        unsigned first, unsigned num, uint32_t value)
 {
+       assert(num >= 1 && num <= 32);
        uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
@@ -64,6 +65,7 @@ static inline void buf_set_u32(uint8_t *_buffer,
 static inline void buf_set_u64(uint8_t *_buffer,
        unsigned first, unsigned num, uint64_t value)
 {
+       assert(num >= 1 && num <= 64);
        uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
@@ -102,6 +104,7 @@ static inline void buf_set_u64(uint8_t *_buffer,
 static inline uint32_t buf_get_u32(const uint8_t *_buffer,
        unsigned first, unsigned num)
 {
+       assert(num >= 1 && num <= 32);
        const uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {
@@ -131,6 +134,7 @@ static inline uint32_t buf_get_u32(const uint8_t *_buffer,
 static inline uint64_t buf_get_u64(const uint8_t *_buffer,
        unsigned first, unsigned num)
 {
+       assert(num >= 1 && num <= 64);
        const uint8_t *buffer = _buffer;
 
        if ((num == 32) && (first == 0)) {

--