This is an automated email from Gerrit.

"Daniel Lizewski <daniellizew...@geotab.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8463

-- gerrit

commit 46f57d8bac2501898443b8cd560fde65b9f83d6f
Author: daniellizewski <daniellizew...@geotab.com>
Date:   Fri Aug 23 08:31:04 2024 -0400

    src/flash/nor/kinetis.c: Fixed flash bank write gap
    
    Flash banks created in kinetis_create_missing_banks did not populate
    bank->minimal_write_gap. The default value of 0 was interpreted as
    FLASH_WRITE_CONTINUOUS. This created unnecessary large padding if your
    binary had a gap in the populated flash. It also caused flash errors
    when loading with GDB because the erroneously padded pages were not
    erased first. Tested using an S32k148 using s32k.cfg.
    
    Change-Id: I9b7af698e29ac2c4f5fc8ecd82fa7f4b1a0d43f1
    Signed-off-by: daniellizewski <daniellizew...@geotab.com>

diff --git a/src/flash/nor/kinetis.c b/src/flash/nor/kinetis.c
index fee36444e6..2d0a75334d 100644
--- a/src/flash/nor/kinetis.c
+++ b/src/flash/nor/kinetis.c
@@ -1038,6 +1038,7 @@ static int kinetis_create_missing_banks(struct 
kinetis_chip *k_chip)
                bank->target = k_chip->target;
                bank->driver = &kinetis_flash;
                bank->default_padded_value = bank->erased_value = 0xff;
+               bank->minimal_write_gap = FLASH_WRITE_GAP_SECTOR;
 
                snprintf(name, sizeof(name), "%s.%s%s",
                         base_name, class, num);

-- 

Reply via email to