This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8494

-- gerrit

commit 1646a5ceaf757f942899850e3de1fedede826294
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Mon Sep 16 11:36:03 2024 +0200

    jtag: stlink_usb: drop comparison to NULL
    
    Fix checkpatch error:
    
            ERROR:COMPARISON_TO_NULL: Comparison to NULL could be
            written "handle"
    
    Change-Id: I0ac12ccfc5fce4dd41266f83eb4b973a4e6a314d
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/jtag/drivers/stlink_usb.c b/src/jtag/drivers/stlink_usb.c
index 8cf3b0c73a..bd5b52b676 100644
--- a/src/jtag/drivers/stlink_usb.c
+++ b/src/jtag/drivers/stlink_usb.c
@@ -2754,7 +2754,7 @@ static int stlink_usb_read_mem32_noaddrinc(void *handle, 
uint8_t ap_num, uint32_
 {
        struct stlink_usb_handle *h = handle;
 
-       assert(handle != NULL);
+       assert(handle);
 
        if (!(h->version.flags & STLINK_F_HAS_MEM_RD_NO_INC))
                return ERROR_COMMAND_NOTFOUND;
@@ -2796,7 +2796,7 @@ static int stlink_usb_write_mem32_noaddrinc(void *handle, 
uint8_t ap_num, uint32
 {
        struct stlink_usb_handle *h = handle;
 
-       assert(handle != NULL);
+       assert(handle);
 
        if (!(h->version.flags & STLINK_F_HAS_MEM_WR_NO_INC))
                return ERROR_COMMAND_NOTFOUND;
@@ -3947,7 +3947,7 @@ static int stlink_usb_rw_misc_out(void *handle, uint32_t 
items, const uint8_t *b
 
        LOG_DEBUG_IO("%s(%" PRIu32 ")", __func__, items);
 
-       assert(handle != NULL);
+       assert(handle);
 
        if (!(h->version.flags & STLINK_F_HAS_RW_MISC))
                return ERROR_COMMAND_NOTFOUND;
@@ -3968,7 +3968,7 @@ static int stlink_usb_rw_misc_in(void *handle, uint32_t 
items, uint8_t *buffer)
 
        LOG_DEBUG_IO("%s(%" PRIu32 ")", __func__, items);
 
-       assert(handle != NULL);
+       assert(handle);
 
        if (!(h->version.flags & STLINK_F_HAS_RW_MISC))
                return ERROR_COMMAND_NOTFOUND;

-- 

Reply via email to