[PATCH]: 7c05e2401e breakpoints: restore watchpoint functionality

[gerrit]

This is an automated email from Gerrit.

"Karl Palsson <ka...@tweak.au>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/8364

-- gerrit

commit 7c05e2401e8399e1fad42d71dc3bb2d39a48ea2a
Author: Karl Palsson <karl.pals...@marel.com>
Date:   Fri Sep 27 11:37:43 2024 +0000

    breakpoints: restore watchpoint functionality
    
    Fixes: 0bf3373e Use 'unsigned int' for length
    
    The above change unintentionally changed the signature of
    watchpoint_add_internal, resulting in truncating masks from 64bit to
    32bit.  This resulted in comparisons against the 64bit value
    WATCHPOINT_IGNORE_DATA_VALUE_MASK to fail, resulting in watchpoints to
    fail to be installed.
    
    Change-Id: Iacf0eb4f5066acbff43d32fa122e2d1e5c4f590b
    Signed-off-by: Karl Palsson <karl.pals...@marel.com>

diff --git a/src/target/breakpoints.c b/src/target/breakpoints.c
index 2fbb69e07a..9378abcb14 100644
--- a/src/target/breakpoints.c
+++ b/src/target/breakpoints.c
@@ -500,7 +500,7 @@ struct breakpoint *breakpoint_find(struct target *target, 
target_addr_t address)
 }
 
 static int watchpoint_add_internal(struct target *target, target_addr_t 
address,
-               unsigned int length, enum watchpoint_rw rw, uint32_t value, 
uint32_t mask)
+               unsigned int length, enum watchpoint_rw rw, uint64_t value, 
uint64_t mask)
 {
        struct watchpoint *watchpoint = target->watchpoints;
        struct watchpoint **watchpoint_p = &target->watchpoints;

--