This is an automated email from Gerrit.
"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8539
-- gerrit
commit a3b5f9b3310fe354569c848d47facaecbdd4fb8c
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date: Mon Apr 10 12:02:55 2023 +0200
checkpatch: exclude gerrit's Change-Id line from commit description
Checkpatch rejects patches that have empty commit description and
logs them with:
WARNING:COMMIT_MESSAGE: Missing commit description - Add an
appropriate one
But if the patch has a gerrit's Change-Id line placed before the
line Signed-off-by, then checkpatch considers the Change-Id line
as a valid commit description text.
Use the Change-Id tag as a marker of the end of the commit message,
thus not counting its line as part of the commit description.
This patch is not relevant for the Linux kernel development process
as gerrit is not involved and the Change-Id tag is rejected. But
other projects, like OpenOCD, base the development on gerrit and
reuse kernel's checkpatch with flag '--ignore GERRIT_CHANGE_ID'.
This patch has been refused [1] in Linux upstream because it has
not been considered relevant for that project.
Let's take it as another add-on in OpenOCD checkpatch.
Change-Id: I3b55b8fffa07ce67177c108e7c9554ca46674246
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
Link: [1]
https://lore.kernel.org/lkml/20230410100255.16755-1-borneo.anto...@gmail.com/
diff --git a/tools/scripts/checkpatch.pl b/tools/scripts/checkpatch.pl
index 01bd547ff5..1011b33055 100755
--- a/tools/scripts/checkpatch.pl
+++ b/tools/scripts/checkpatch.pl
@@ -3251,6 +3251,9 @@ sub process {
# Check for Gerrit Change-Ids not in any patch context
if ($realfile eq '' && !$has_patch_separator && $line =~
/^\s*change-id:/i) {
+ # OpenOCD specific: Begin: exclude gerrit's Change-Id
line from commit description
+ $in_commit_log = 0;
+ # OpenOCD specific: End
if (ERROR("GERRIT_CHANGE_ID",
"Remove Gerrit Change-Id's before submitting
upstream\n" . $herecurr) &&
$fix) {
--
