[PATCH]: 438e344d1a jtag: core: make local functions static

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8542

-- gerrit

commit 438e344d1a72b654740b643235325d87b5a420e2
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat Nov 9 19:29:43 2024 +0100

    jtag: core: make local functions static
    
    The functions:
    - jtag_error_clear();
    - jtag_tap_count();
    are not referenced outside the file.
    
    Make them static.
    
    Change-Id: I00fcf06b1838b9f6c955c19772f1d41d486459e9
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/jtag/core.c b/src/jtag/core.c
index 907883f099..769e07571f 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -51,6 +51,8 @@ static void jtag_add_scan_check(struct jtag_tap *active,
                tap_state_t state),
                int in_num_fields, struct scan_field *in_fields, tap_state_t 
state);
 
+static int jtag_error_clear(void);
+
 /**
  * The jtag_error variable is set when an error occurs while executing
  * the queue.  Application code may set this using jtag_set_error(),
@@ -127,7 +129,11 @@ void jtag_set_error(int error)
        jtag_error = error;
 }
 
-int jtag_error_clear(void)
+/**
+ * Resets jtag_error to ERROR_OK, returning its previous value.
+ * @returns The previous value of @c jtag_error.
+ */
+static int jtag_error_clear(void)
 {
        int temp = jtag_error;
        jtag_error = ERROR_OK;
@@ -186,7 +192,7 @@ struct jtag_tap *jtag_all_taps(void)
        return __jtag_all_taps;
 };
 
-unsigned int jtag_tap_count(void)
+static unsigned int jtag_tap_count(void)
 {
        struct jtag_tap *t = jtag_all_taps();
        unsigned int n = 0;
diff --git a/src/jtag/jtag.h b/src/jtag/jtag.h
index b9d37b32ae..86526a09a1 100644
--- a/src/jtag/jtag.h
+++ b/src/jtag/jtag.h
@@ -153,7 +153,6 @@ struct jtag_tap *jtag_tap_by_jim_obj(Jim_Interp *interp, 
Jim_Obj *obj);
 struct jtag_tap *jtag_tap_by_position(unsigned int abs_position);
 struct jtag_tap *jtag_tap_next_enabled(struct jtag_tap *p);
 unsigned int jtag_tap_count_enabled(void);
-unsigned int jtag_tap_count(void);
 
 /*
  * - TRST_ASSERTED triggers two sets of callbacks, after operations to
@@ -568,11 +567,6 @@ void jtag_sleep(uint32_t us);
  * called with a non-zero error code.
  */
 void jtag_set_error(int error);
-/**
- * Resets jtag_error to ERROR_OK, returning its previous value.
- * @returns The previous value of @c jtag_error.
- */
-int jtag_error_clear(void);
 
 /**
  * Return true if it's safe for a background polling task to access the

--