This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8543

-- gerrit

commit f1c02765f6e6e73b7b91560ebbbc793c47f876e1
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sat Nov 9 19:39:11 2024 +0100

    jtag: driver: make local functions static
    
    The functions:
    - interface_jtag_add_callback();
    - interface_jtag_add_callback4();
    are not referenced outside the file.
    
    Make them static.
    
    Change-Id: I84f738309d23c8d0b5329aa04436db750cf185e5
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/jtag/drivers/driver.c b/src/jtag/drivers/driver.c
index d52a345a0a..58e59a559f 100644
--- a/src/jtag/drivers/driver.c
+++ b/src/jtag/drivers/driver.c
@@ -341,7 +341,7 @@ int interface_jtag_add_sleep(uint32_t us)
 }
 
 /* add callback to end of queue */
-void interface_jtag_add_callback4(jtag_callback_t callback,
+static void interface_jtag_add_callback4(jtag_callback_t callback,
                jtag_callback_data_t data0, jtag_callback_data_t data1,
                jtag_callback_data_t data2, jtag_callback_data_t data3)
 {
@@ -395,7 +395,7 @@ static int jtag_convert_to_callback4(jtag_callback_data_t 
data0,
        return ERROR_OK;
 }
 
-void interface_jtag_add_callback(jtag_callback1_t callback, 
jtag_callback_data_t data0)
+static void interface_jtag_add_callback(jtag_callback1_t callback, 
jtag_callback_data_t data0)
 {
        jtag_add_callback4(jtag_convert_to_callback4, data0, 
(jtag_callback_data_t)callback, 0, 0);
 }
diff --git a/src/jtag/drivers/minidriver_imp.h 
b/src/jtag/drivers/minidriver_imp.h
index b29b3c9cca..f3582f6e34 100644
--- a/src/jtag/drivers/minidriver_imp.h
+++ b/src/jtag/drivers/minidriver_imp.h
@@ -17,12 +17,6 @@ static inline void 
interface_jtag_add_scan_check_alloc(struct scan_field *field)
        field->in_value = cmd_queue_alloc(num_bytes);
 }
 
-void interface_jtag_add_callback(jtag_callback1_t f, jtag_callback_data_t 
data0);
-
-void interface_jtag_add_callback4(jtag_callback_t f, jtag_callback_data_t 
data0,
-                                 jtag_callback_data_t data1, 
jtag_callback_data_t data2,
-                                 jtag_callback_data_t data3);
-
 void jtag_add_callback4(jtag_callback_t f, jtag_callback_data_t data0,
                        jtag_callback_data_t data1, jtag_callback_data_t data2,
                        jtag_callback_data_t data3);

-- 

Reply via email to