I am adding support for the new PIC32CZ family from Microchip. Confusingly these bear no relation to the original PIC32 devices and are actually relatively powerful ARM Cortex7 MCUs. The internal flash controller does bear some similarity with the already supported PIC32MX implementation but not enough to warrant extending that driver (IMHO).
I have written a new flash driver to support the internal flash banks of the various devices in the family. It is currently working in Visual Studio Code with OpenOCD master running on MacOS Apple Silicon via JLink interface to a Microchip CA80 Curiosity evaluation board. I am using the GNU ARM v13 toolchain in preference to the Microchip compilers so connecting via the GNU arm-none-eabi-gdb. My question is whether I need to add any documentation besides the usual doxygen comments. There isn't a whole lot to write about but I would like to record extended arguments to flash banks (for example supporting the pre-prog flash modes) I have a Gerrit commit ready to push for review subject to a few improvements I'd like to make first. I am new to OpenOCD so still feeling my way around the internals. Thanks for any pointers.