This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8700

-- gerrit

commit 9f1591b4dfcd337789b8d8e7ddc5727264470472
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Fri Jan 10 13:55:18 2025 +0100

    drivers: rshim: drop useless typedef
    
    Use 'struct name' instead of typedef.
    
    Change-Id: Ifff56811f53a260c314c8f5473d368599e0912e6
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/jtag/drivers/rshim.c b/src/jtag/drivers/rshim.c
index 21fc7fd378..b37fe8c453 100644
--- a/src/jtag/drivers/rshim.c
+++ b/src/jtag/drivers/rshim.c
@@ -60,14 +60,14 @@
 
 #ifdef HAVE_SYS_IOCTL_H
 /* Message used to program rshim via ioctl(). */
-typedef struct {
+struct rshim_ioctl_msg {
        uint32_t addr;
        uint64_t data;
-} __attribute__((packed)) rshim_ioctl_msg;
+} __attribute__((packed));
 
 enum {
-       RSH_IOC_READ = _IOWR('R', 0, rshim_ioctl_msg),
-       RSH_IOC_WRITE = _IOWR('R', 1, rshim_ioctl_msg),
+       RSH_IOC_READ = _IOWR('R', 0, struct rshim_ioctl_msg),
+       RSH_IOC_WRITE = _IOWR('R', 1, struct rshim_ioctl_msg),
 };
 #endif
 
@@ -104,7 +104,7 @@ static int rshim_dev_read(int chan, int addr, uint64_t 
*value)
 
 #ifdef HAVE_SYS_IOCTL_H
        if (rc < 0 && errno == ENOSYS) {
-               rshim_ioctl_msg msg;
+               struct rshim_ioctl_msg msg;
 
                msg.addr = addr;
                msg.data = 0;
@@ -126,7 +126,7 @@ static int rshim_dev_write(int chan, int addr, uint64_t 
value)
 
 #ifdef HAVE_SYS_IOCTL_H
        if (rc < 0 && errno == ENOSYS) {
-               rshim_ioctl_msg msg;
+               struct rshim_ioctl_msg msg;
 
                msg.addr = addr;
                msg.data = value;

-- 

Reply via email to