[PATCH]: 1ab8169f2e openocd: drop useless typedef

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8699

-- gerrit

commit 1ab8169f2e354cf3643d70279b66a2c41715bad9
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Fri Jan 10 13:40:59 2025 +0100

    openocd: drop useless typedef
    
    There is no need to use typedef for the array of functions.
    Drop it.
    
    While there, move the declaration outside the function and use the
    array size to drop the error-prone sentinel to NULL.
    
    Change-Id: I424964a6ef82ed1a7b27e78fbd19aa9f985b52c7
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/openocd.c b/src/openocd.c
index 9fd709e323..3fbece3955 100644
--- a/src/openocd.c
+++ b/src/openocd.c
@@ -232,6 +232,23 @@ static int openocd_register_commands(struct 
command_context *cmd_ctx)
 
 struct command_context *global_cmd_ctx;
 
+static int (* const command_registrants[])(struct command_context 
*cmd_ctx_value) = {
+       openocd_register_commands,
+       server_register_commands,
+       gdb_register_commands,
+       log_register_commands,
+       rtt_server_register_commands,
+       transport_register_commands,
+       adapter_register_commands,
+       target_register_commands,
+       flash_register_commands,
+       nand_register_commands,
+       pld_register_commands,
+       cti_register_commands,
+       dap_register_commands,
+       arm_tpiu_swo_register_commands,
+};
+
 static struct command_context *setup_command_handler(Jim_Interp *interp)
 {
        log_init();
@@ -240,25 +257,7 @@ static struct command_context 
*setup_command_handler(Jim_Interp *interp)
        struct command_context *cmd_ctx = command_init(openocd_startup_tcl, 
interp);
 
        /* register subsystem commands */
-       typedef int (*command_registrant_t)(struct command_context 
*cmd_ctx_value);
-       static const command_registrant_t command_registrants[] = {
-               &openocd_register_commands,
-               &server_register_commands,
-               &gdb_register_commands,
-               &log_register_commands,
-               &rtt_server_register_commands,
-               &transport_register_commands,
-               &adapter_register_commands,
-               &target_register_commands,
-               &flash_register_commands,
-               &nand_register_commands,
-               &pld_register_commands,
-               &cti_register_commands,
-               &dap_register_commands,
-               &arm_tpiu_swo_register_commands,
-               NULL
-       };
-       for (unsigned int i = 0; command_registrants[i]; i++) {
+       for (unsigned int i = 0; i < ARRAY_SIZE(command_registrants); i++) {
                int retval = (*command_registrants[i])(cmd_ctx);
                if (retval != ERROR_OK) {
                        command_done(cmd_ctx);

--