This is an automated email from Gerrit.
"Marek Vrbka <marek.vr...@codasip.com>" just uploaded a new patch set to
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8717
-- gerrit
commit f0346a7f9f39b3d4e5a05291a5fa4d930c9604bb
Author: Marek Vrbka <marek.vr...@codasip.com>
Date: Mon Jan 13 10:28:15 2025 +0100
vdebug: Fix socket comparison warning on Windows
On GCC version 13.2,
the previous code emitted the following warning on Windows:
openocd/src/jtag/drivers/vdebug.c:254:19: warning: comparison of integer
expressions of different signedness: 'int' and 'long long unsigned int'
[-Wsign-compare]
254 | if (hsock == INVALID_SOCKET)
This patch fixes it and brings it in line with other socket handling code.
Change-Id: I7e05f83c6905cfaf66b68e8988c783e80cee4a48
Signed-off-by: Marek Vrbka <marek.vr...@codasip.com>
diff --git a/src/jtag/drivers/vdebug.c b/src/jtag/drivers/vdebug.c
index 691e576e53..20819f70bd 100644
--- a/src/jtag/drivers/vdebug.c
+++ b/src/jtag/drivers/vdebug.c
@@ -252,7 +252,7 @@ static int vdebug_socket_open(char *server_addr, uint32_t
port)
#ifdef _WIN32
hsock = socket(AF_INET, SOCK_STREAM, IPPROTO_IP);
- if (hsock == INVALID_SOCKET)
+ if (hsock < 0)
rc = vdebug_socket_error();
#elif defined __CYGWIN__
/* SO_RCVLOWAT unsupported on CYGWIN */
--
