[PATCH]: 243ff24f8b jtag/core: fix segfault when adapter driver has no reset method

[gerrit]

This is an automated email from Gerrit.

"Tomas Vanek <van...@fbl.cz>" just uploaded a new patch set to Gerrit, which 
you can find at https://review.openocd.org/c/openocd/+/8735

-- gerrit

commit 243ff24f8b307217d6c8bfedeb4a68ce4ba93d66
Author: Tomas Vanek <van...@fbl.cz>
Date:   Mon Feb 3 21:45:07 2025 +0100

    jtag/core: fix segfault when adapter driver has no reset method
    
    xlnx-pcie-xvc and linuxspidev adapter drivers does not implement
    the reset method.
    Although its likely both adapters will implement the method in
    the near future, avoid segfault and return an error instead.
    
    Change-Id: If8ddf165dbc563cf6d64b2094968151075778ba7
    Signed-off-by: Tomas Vanek <van...@fbl.cz>
    Fixes: commit 8850eb8f2c51 ("swd: get rid of jtag queue to assert/deassert 
srst")

diff --git a/src/jtag/core.c b/src/jtag/core.c
index 769e07571f..9afdb0ff92 100644
--- a/src/jtag/core.c
+++ b/src/jtag/core.c
@@ -631,6 +631,13 @@ static int adapter_system_reset(int req_srst)
 
        /* Maybe change SRST signal state */
        if (jtag_srst != req_srst) {
+               if (!adapter_driver->reset) {
+                       if (req_srst)
+                               LOG_ERROR("Adapter driver does not implement 
SRST handling");
+
+                       return ERROR_NOT_IMPLEMENTED;
+               }
+
                retval = adapter_driver->reset(0, req_srst);
                if (retval != ERROR_OK) {
                        LOG_ERROR("SRST error");

--