This is an automated email from Gerrit.
"Jan Matyas <jan.mat...@codasip.com>" just uploaded a new patch set to Gerrit,
which you can find at https://review.openocd.org/c/openocd/+/8749
-- gerrit
commit 171b8d01b06a20840c3c228b0d426b0c953d506d
Author: Jan Matyas <jan.mat...@codasip.com>
Date: Sun Feb 9 18:18:44 2025 +0100
helper/types: Avoid -Wconversion warnings
Avoid -Wconversion warnings in types.h.
These warnings are not enabled during OpenOCD build as of now,
but hopefully we will get there one day.
While there, remove spaces after casts because checkpatch is
not fond of them.
Change-Id: I104ff7a5bb56f006fe040b95556bbc355e409763
Signed-off-by: Jan Matyas <jan.mat...@codasip.com>
diff --git a/src/helper/types.h b/src/helper/types.h
index 53249e5b79..0b690904fb 100644
--- a/src/helper/types.h
+++ b/src/helper/types.h
@@ -153,68 +153,68 @@ static inline uint16_t be_to_h_u16(const uint8_t *buf)
static inline void h_u64_to_le(uint8_t *buf, uint64_t val)
{
- buf[7] = (uint8_t) (val >> 56);
- buf[6] = (uint8_t) (val >> 48);
- buf[5] = (uint8_t) (val >> 40);
- buf[4] = (uint8_t) (val >> 32);
- buf[3] = (uint8_t) (val >> 24);
- buf[2] = (uint8_t) (val >> 16);
- buf[1] = (uint8_t) (val >> 8);
- buf[0] = (uint8_t) (val >> 0);
+ buf[7] = (uint8_t)(val >> 56);
+ buf[6] = (uint8_t)(val >> 48);
+ buf[5] = (uint8_t)(val >> 40);
+ buf[4] = (uint8_t)(val >> 32);
+ buf[3] = (uint8_t)(val >> 24);
+ buf[2] = (uint8_t)(val >> 16);
+ buf[1] = (uint8_t)(val >> 8);
+ buf[0] = (uint8_t)(val >> 0);
}
static inline void h_u64_to_be(uint8_t *buf, uint64_t val)
{
- buf[0] = (uint8_t) (val >> 56);
- buf[1] = (uint8_t) (val >> 48);
- buf[2] = (uint8_t) (val >> 40);
- buf[3] = (uint8_t) (val >> 32);
- buf[4] = (uint8_t) (val >> 24);
- buf[5] = (uint8_t) (val >> 16);
- buf[6] = (uint8_t) (val >> 8);
- buf[7] = (uint8_t) (val >> 0);
+ buf[0] = (uint8_t)(val >> 56);
+ buf[1] = (uint8_t)(val >> 48);
+ buf[2] = (uint8_t)(val >> 40);
+ buf[3] = (uint8_t)(val >> 32);
+ buf[4] = (uint8_t)(val >> 24);
+ buf[5] = (uint8_t)(val >> 16);
+ buf[6] = (uint8_t)(val >> 8);
+ buf[7] = (uint8_t)(val >> 0);
}
static inline void h_u32_to_le(uint8_t *buf, uint32_t val)
{
- buf[3] = (val >> 24) & 0xff;
- buf[2] = (val >> 16) & 0xff;
- buf[1] = (val >> 8) & 0xff;
- buf[0] = (val >> 0) & 0xff;
+ buf[3] = (uint8_t)((val >> 24) & 0xff);
+ buf[2] = (uint8_t)((val >> 16) & 0xff);
+ buf[1] = (uint8_t)((val >> 8) & 0xff);
+ buf[0] = (uint8_t)((val >> 0) & 0xff);
}
static inline void h_u32_to_be(uint8_t *buf, uint32_t val)
{
- buf[0] = (val >> 24) & 0xff;
- buf[1] = (val >> 16) & 0xff;
- buf[2] = (val >> 8) & 0xff;
- buf[3] = (val >> 0) & 0xff;
+ buf[0] = (uint8_t)((val >> 24) & 0xff);
+ buf[1] = (uint8_t)((val >> 16) & 0xff);
+ buf[2] = (uint8_t)((val >> 8) & 0xff);
+ buf[3] = (uint8_t)((val >> 0) & 0xff);
}
static inline void h_u24_to_le(uint8_t *buf, unsigned int val)
{
- buf[2] = (val >> 16) & 0xff;
- buf[1] = (val >> 8) & 0xff;
- buf[0] = (val >> 0) & 0xff;
+ buf[2] = (uint8_t)((val >> 16) & 0xff);
+ buf[1] = (uint8_t)((val >> 8) & 0xff);
+ buf[0] = (uint8_t)((val >> 0) & 0xff);
}
static inline void h_u24_to_be(uint8_t *buf, unsigned int val)
{
- buf[0] = (val >> 16) & 0xff;
- buf[1] = (val >> 8) & 0xff;
- buf[2] = (val >> 0) & 0xff;
+ buf[0] = (uint8_t)((val >> 16) & 0xff);
+ buf[1] = (uint8_t)((val >> 8) & 0xff);
+ buf[2] = (uint8_t)((val >> 0) & 0xff);
}
static inline void h_u16_to_le(uint8_t *buf, uint16_t val)
{
- buf[1] = (val >> 8) & 0xff;
- buf[0] = (val >> 0) & 0xff;
+ buf[1] = (uint8_t)((val >> 8) & 0xff);
+ buf[0] = (uint8_t)((val >> 0) & 0xff);
}
static inline void h_u16_to_be(uint8_t *buf, uint16_t val)
{
- buf[0] = (val >> 8) & 0xff;
- buf[1] = (val >> 0) & 0xff;
+ buf[0] = (uint8_t)((val >> 8) & 0xff);
+ buf[1] = (uint8_t)((val >> 0) & 0xff);
}
/**
--
