This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8825

-- gerrit

commit c28b4c0594bd33e9c99e7972519f01cf92073aa4
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Apr 6 01:20:44 2025 +0200

    target: don't free working areas during 'configure -chain-position'
    
    Since commit ef1cfb23947b ("Duane Ellis: "target as an [tcl]
    object" feature.") merged in 2008, the commands:
            $target_name configure -chain-position ...
            target create ... -chain-position ...
    cause the allocated working area to be freed.
    
    There is no reason for this, it is probably caused by an incorrect
    copy/paste from the author.
    
    Drop the call to target_free_all_working_areas().
    
    Change-Id: I61a9303afe7fee6953669218330635c0b965b20d
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>

diff --git a/src/target/target.c b/src/target/target.c
index 8c5c8e5e30..36ad0eec83 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -5128,7 +5128,6 @@ no_params:
                                        return JIM_ERR;
                                }
 
-                               target_free_all_working_areas(target);
                                e = jim_getopt_obj(goi, &o_t);
                                if (e != JIM_OK)
                                        return e;

-- 

Reply via email to