This is an automated email from Gerrit.
"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8831
-- gerrit
commit 7546a9c5d6aa3370ae8111adbba7df5ffd96c7af
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date: Sun Apr 6 14:10:28 2025 +0200
target: drop unused parameter to target_create()
The parameter Jim_Interp to the target API target_create() is not
used by any target.
Drop it.
Change-Id: I67c492078a6c808db974505f9e297c45165f64d0
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
diff --git a/src/target/aarch64.c b/src/target/aarch64.c
index ce7808e3ac..101cb14408 100644
--- a/src/target/aarch64.c
+++ b/src/target/aarch64.c
@@ -2814,7 +2814,7 @@ static int aarch64_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int armv8r_target_create(struct target *target, Jim_Interp *interp)
+static int armv8r_target_create(struct target *target)
{
struct aarch64_private_config *pc = target->private_config;
struct aarch64_common *aarch64;
@@ -2833,7 +2833,7 @@ static int armv8r_target_create(struct target *target,
Jim_Interp *interp)
return aarch64_init_arch_info(target, aarch64, pc->adiv5_config.dap);
}
-static int aarch64_target_create(struct target *target, Jim_Interp *interp)
+static int aarch64_target_create(struct target *target)
{
struct aarch64_private_config *pc = target->private_config;
struct aarch64_common *aarch64;
diff --git a/src/target/arc.c b/src/target/arc.c
index 8757cafedc..f2482c25ef 100644
--- a/src/target/arc.c
+++ b/src/target/arc.c
@@ -1424,7 +1424,7 @@ static void arc_deinit_target(struct target *target)
}
-static int arc_target_create(struct target *target, Jim_Interp *interp)
+static int arc_target_create(struct target *target)
{
struct arc_common *arc = calloc(1, sizeof(*arc));
diff --git a/src/target/arm11.c b/src/target/arm11.c
index 756b36b959..583830f948 100644
--- a/src/target/arm11.c
+++ b/src/target/arm11.c
@@ -1079,7 +1079,7 @@ static int arm11_remove_breakpoint(struct target *target,
return ERROR_OK;
}
-static int arm11_target_create(struct target *target, Jim_Interp *interp)
+static int arm11_target_create(struct target *target)
{
struct arm11_common *arm11;
diff --git a/src/target/arm720t.c b/src/target/arm720t.c
index beab632c25..d1433dde72 100644
--- a/src/target/arm720t.c
+++ b/src/target/arm720t.c
@@ -412,7 +412,7 @@ static int arm720t_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int arm720t_target_create(struct target *target, Jim_Interp *interp)
+static int arm720t_target_create(struct target *target)
{
struct arm720t_common *arm720t = calloc(1, sizeof(*arm720t));
diff --git a/src/target/arm7tdmi.c b/src/target/arm7tdmi.c
index 393d3b46af..2f59254afd 100644
--- a/src/target/arm7tdmi.c
+++ b/src/target/arm7tdmi.c
@@ -669,7 +669,7 @@ int arm7tdmi_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int arm7tdmi_target_create(struct target *target, Jim_Interp *interp)
+static int arm7tdmi_target_create(struct target *target)
{
struct arm7_9_common *arm7_9;
diff --git a/src/target/arm920t.c b/src/target/arm920t.c
index 53b4d9d15f..95cfd7ceb2 100644
--- a/src/target/arm920t.c
+++ b/src/target/arm920t.c
@@ -833,7 +833,7 @@ static int arm920t_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int arm920t_target_create(struct target *target, Jim_Interp *interp)
+static int arm920t_target_create(struct target *target)
{
struct arm920t_common *arm920t;
diff --git a/src/target/arm926ejs.c b/src/target/arm926ejs.c
index add90c9978..0531106562 100644
--- a/src/target/arm926ejs.c
+++ b/src/target/arm926ejs.c
@@ -702,7 +702,7 @@ int arm926ejs_init_arch_info(struct target *target, struct
arm926ejs_common *arm
return ERROR_OK;
}
-static int arm926ejs_target_create(struct target *target, Jim_Interp *interp)
+static int arm926ejs_target_create(struct target *target)
{
struct arm926ejs_common *arm926ejs = calloc(1, sizeof(struct
arm926ejs_common));
diff --git a/src/target/arm946e.c b/src/target/arm946e.c
index 03f7e443fb..828e70f4bc 100644
--- a/src/target/arm946e.c
+++ b/src/target/arm946e.c
@@ -79,7 +79,7 @@ static int arm946e_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int arm946e_target_create(struct target *target, Jim_Interp *interp)
+static int arm946e_target_create(struct target *target)
{
struct arm946e_common *arm946e = calloc(1, sizeof(struct
arm946e_common));
diff --git a/src/target/arm966e.c b/src/target/arm966e.c
index 8598d29d9b..b6bcc8ba97 100644
--- a/src/target/arm966e.c
+++ b/src/target/arm966e.c
@@ -38,7 +38,7 @@ int arm966e_init_arch_info(struct target *target, struct
arm966e_common *arm966e
return ERROR_OK;
}
-static int arm966e_target_create(struct target *target, Jim_Interp *interp)
+static int arm966e_target_create(struct target *target)
{
struct arm966e_common *arm966e = calloc(1, sizeof(struct
arm966e_common));
diff --git a/src/target/arm9tdmi.c b/src/target/arm9tdmi.c
index 7e31306b6c..8ab12de320 100644
--- a/src/target/arm9tdmi.c
+++ b/src/target/arm9tdmi.c
@@ -765,7 +765,7 @@ int arm9tdmi_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int arm9tdmi_target_create(struct target *target, Jim_Interp *interp)
+static int arm9tdmi_target_create(struct target *target)
{
struct arm7_9_common *arm7_9 = calloc(1, sizeof(struct arm7_9_common));
diff --git a/src/target/avr32_ap7k.c b/src/target/avr32_ap7k.c
index 1b051dc014..94962c2055 100644
--- a/src/target/avr32_ap7k.c
+++ b/src/target/avr32_ap7k.c
@@ -510,7 +510,7 @@ static int avr32_ap7k_init_target(struct command_context
*cmd_ctx,
return ERROR_OK;
}
-static int avr32_ap7k_target_create(struct target *target, Jim_Interp *interp)
+static int avr32_ap7k_target_create(struct target *target)
{
struct avr32_ap7k_common *ap7k = calloc(1, sizeof(struct
avr32_ap7k_common));
diff --git a/src/target/avrt.c b/src/target/avrt.c
index 3afe320157..e25718bcc2 100644
--- a/src/target/avrt.c
+++ b/src/target/avrt.c
@@ -16,7 +16,7 @@
#define AVR_JTAG_INS_LEN 4
/* forward declarations */
-static int avr_target_create(struct target *target, Jim_Interp *interp);
+static int avr_target_create(struct target *target);
static int avr_init_target(struct command_context *cmd_ctx, struct target
*target);
static int avr_arch_state(struct target *target);
@@ -68,7 +68,7 @@ struct target_type avr_target = {
.init_target = avr_init_target,
};
-static int avr_target_create(struct target *target, Jim_Interp *interp)
+static int avr_target_create(struct target *target)
{
struct avr_common *avr = calloc(1, sizeof(struct avr_common));
diff --git a/src/target/cortex_a.c b/src/target/cortex_a.c
index 9c60645586..ee27e1b217 100644
--- a/src/target/cortex_a.c
+++ b/src/target/cortex_a.c
@@ -3126,7 +3126,7 @@ static int cortex_a_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int cortex_a_target_create(struct target *target, Jim_Interp *interp)
+static int cortex_a_target_create(struct target *target)
{
struct cortex_a_common *cortex_a;
struct adiv5_private_config *pc;
@@ -3148,7 +3148,7 @@ static int cortex_a_target_create(struct target *target,
Jim_Interp *interp)
return cortex_a_init_arch_info(target, cortex_a, pc->dap);
}
-static int cortex_r4_target_create(struct target *target, Jim_Interp *interp)
+static int cortex_r4_target_create(struct target *target)
{
struct cortex_a_common *cortex_a;
struct adiv5_private_config *pc;
diff --git a/src/target/cortex_m.c b/src/target/cortex_m.c
index e17f23c1d3..ba9d83d79f 100644
--- a/src/target/cortex_m.c
+++ b/src/target/cortex_m.c
@@ -2916,7 +2916,7 @@ static int cortex_m_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int cortex_m_target_create(struct target *target, Jim_Interp *interp)
+static int cortex_m_target_create(struct target *target)
{
struct adiv5_private_config *pc;
diff --git a/src/target/dsp563xx.c b/src/target/dsp563xx.c
index 9b6f4756c9..dc85a21800 100644
--- a/src/target/dsp563xx.c
+++ b/src/target/dsp563xx.c
@@ -880,7 +880,7 @@ static void dsp563xx_invalidate_x_context(struct target
*target,
}
}
-static int dsp563xx_target_create(struct target *target, Jim_Interp *interp)
+static int dsp563xx_target_create(struct target *target)
{
struct dsp563xx_common *dsp563xx = calloc(1, sizeof(struct
dsp563xx_common));
diff --git a/src/target/dsp5680xx.c b/src/target/dsp5680xx.c
index 3f9a6742c4..65efbae324 100644
--- a/src/target/dsp5680xx.c
+++ b/src/target/dsp5680xx.c
@@ -855,7 +855,7 @@ static int eonce_pc_store(struct target *target)
return ERROR_OK;
}
-static int dsp5680xx_target_create(struct target *target, Jim_Interp *interp)
+static int dsp5680xx_target_create(struct target *target)
{
struct dsp5680xx_common *dsp5680xx =
calloc(1, sizeof(struct dsp5680xx_common));
diff --git a/src/target/esirisc.c b/src/target/esirisc.c
index da40928da9..fac5dc72ee 100644
--- a/src/target/esirisc.c
+++ b/src/target/esirisc.c
@@ -1575,7 +1575,7 @@ static int esirisc_identify(struct target *target)
return ERROR_OK;
}
-static int esirisc_target_create(struct target *target, Jim_Interp *interp)
+static int esirisc_target_create(struct target *target)
{
struct jtag_tap *tap = target->tap;
struct esirisc_common *esirisc;
diff --git a/src/target/espressif/esp32.c b/src/target/espressif/esp32.c
index 4deb5e0709..399ba8e7cd 100644
--- a/src/target/espressif/esp32.c
+++ b/src/target/espressif/esp32.c
@@ -326,7 +326,7 @@ static const struct esp_semihost_ops esp32_semihost_ops = {
.prepare = esp32_disable_wdts
};
-static int esp32_target_create(struct target *target, Jim_Interp *interp)
+static int esp32_target_create(struct target *target)
{
struct xtensa_debug_module_config esp32_dm_cfg = {
.dbg_ops = &esp32_dbg_ops,
diff --git a/src/target/espressif/esp32s2.c b/src/target/espressif/esp32s2.c
index 4f3914f66a..b86e43e626 100644
--- a/src/target/espressif/esp32s2.c
+++ b/src/target/espressif/esp32s2.c
@@ -445,7 +445,7 @@ static const struct esp_semihost_ops esp32s2_semihost_ops =
{
.prepare = esp32s2_disable_wdts
};
-static int esp32s2_target_create(struct target *target, Jim_Interp *interp)
+static int esp32s2_target_create(struct target *target)
{
struct xtensa_debug_module_config esp32s2_dm_cfg = {
.dbg_ops = &esp32s2_dbg_ops,
diff --git a/src/target/espressif/esp32s3.c b/src/target/espressif/esp32s3.c
index 7507c11c24..82413f77fb 100644
--- a/src/target/espressif/esp32s3.c
+++ b/src/target/espressif/esp32s3.c
@@ -320,7 +320,7 @@ static const struct esp_semihost_ops esp32s3_semihost_ops =
{
.prepare = esp32s3_disable_wdts
};
-static int esp32s3_target_create(struct target *target, Jim_Interp *interp)
+static int esp32s3_target_create(struct target *target)
{
struct xtensa_debug_module_config esp32s3_dm_cfg = {
.dbg_ops = &esp32s3_dbg_ops,
diff --git a/src/target/fa526.c b/src/target/fa526.c
index 38b7ab2e9d..d832d3e7d1 100644
--- a/src/target/fa526.c
+++ b/src/target/fa526.c
@@ -329,7 +329,7 @@ static int fa526_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int fa526_target_create(struct target *target, Jim_Interp *interp)
+static int fa526_target_create(struct target *target)
{
struct arm920t_common *arm920t = calloc(1, sizeof(struct
arm920t_common));
diff --git a/src/target/feroceon.c b/src/target/feroceon.c
index 840ca1b62b..cf2c838b7d 100644
--- a/src/target/feroceon.c
+++ b/src/target/feroceon.c
@@ -622,7 +622,7 @@ static void feroceon_common_setup(struct target *target)
arm7_9->wp1_used_default = -1;
}
-static int feroceon_target_create(struct target *target, Jim_Interp *interp)
+static int feroceon_target_create(struct target *target)
{
struct arm926ejs_common *arm926ejs = calloc(1, sizeof(struct
arm926ejs_common));
@@ -640,7 +640,7 @@ static int feroceon_target_create(struct target *target,
Jim_Interp *interp)
return ERROR_OK;
}
-static int dragonite_target_create(struct target *target, Jim_Interp *interp)
+static int dragonite_target_create(struct target *target)
{
struct arm966e_common *arm966e = calloc(1, sizeof(struct
arm966e_common));
diff --git a/src/target/hla_target.c b/src/target/hla_target.c
index ef05df2027..983cd87394 100644
--- a/src/target/hla_target.c
+++ b/src/target/hla_target.c
@@ -187,8 +187,7 @@ static int adapter_init_target(struct command_context
*cmd_ctx,
return ERROR_OK;
}
-static int adapter_target_create(struct target *target,
- Jim_Interp *interp)
+static int adapter_target_create(struct target *target)
{
LOG_DEBUG("%s", __func__);
struct adiv5_private_config *pc = target->private_config;
diff --git a/src/target/ls1_sap.c b/src/target/ls1_sap.c
index 692f4cc9e4..49335a8b9f 100644
--- a/src/target/ls1_sap.c
+++ b/src/target/ls1_sap.c
@@ -17,7 +17,7 @@ struct ls1_sap {
struct jtag_tap *tap;
};
-static int ls1_sap_target_create(struct target *target, Jim_Interp *interp)
+static int ls1_sap_target_create(struct target *target)
{
struct ls1_sap *ls1_sap = calloc(1, sizeof(struct ls1_sap));
diff --git a/src/target/mem_ap.c b/src/target/mem_ap.c
index fdc52c3071..c5618c9ccd 100644
--- a/src/target/mem_ap.c
+++ b/src/target/mem_ap.c
@@ -24,7 +24,7 @@ struct mem_ap {
uint64_t ap_num;
};
-static int mem_ap_target_create(struct target *target, Jim_Interp *interp)
+static int mem_ap_target_create(struct target *target)
{
struct mem_ap *mem_ap;
struct adiv5_private_config *pc;
diff --git a/src/target/mips_m4k.c b/src/target/mips_m4k.c
index dc74501086..4e27914a9d 100644
--- a/src/target/mips_m4k.c
+++ b/src/target/mips_m4k.c
@@ -1158,7 +1158,7 @@ static int mips_m4k_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int mips_m4k_target_create(struct target *target, Jim_Interp *interp)
+static int mips_m4k_target_create(struct target *target)
{
struct mips_m4k_common *mips_m4k = calloc(1, sizeof(struct
mips_m4k_common));
diff --git a/src/target/mips_mips64.c b/src/target/mips_mips64.c
index 85e3779375..a181a154ee 100644
--- a/src/target/mips_mips64.c
+++ b/src/target/mips_mips64.c
@@ -1082,7 +1082,7 @@ static int mips_mips64_init_target(struct command_context
*cmd_ctx,
return mips64_build_reg_cache(target);
}
-static int mips_mips64_target_create(struct target *target, Jim_Interp *interp)
+static int mips_mips64_target_create(struct target *target)
{
struct mips_mips64_common *mips_mips64;
struct mips64_common *mips64;
diff --git a/src/target/openrisc/or1k.c b/src/target/openrisc/or1k.c
index 4b9d3bca68..4aa2bd7347 100644
--- a/src/target/openrisc/or1k.c
+++ b/src/target/openrisc/or1k.c
@@ -1097,7 +1097,7 @@ static int or1k_init_target(struct command_context
*cmd_ctx,
return ERROR_OK;
}
-static int or1k_target_create(struct target *target, Jim_Interp *interp)
+static int or1k_target_create(struct target *target)
{
if (!target->tap)
return ERROR_FAIL;
diff --git a/src/target/quark_d20xx.c b/src/target/quark_d20xx.c
index 90cf6670ec..931f0dab7d 100644
--- a/src/target/quark_d20xx.c
+++ b/src/target/quark_d20xx.c
@@ -32,7 +32,7 @@
#include "lakemont.h"
#include "x86_32_common.h"
-static int quark_d20xx_target_create(struct target *t, Jim_Interp *interp)
+static int quark_d20xx_target_create(struct target *t)
{
struct x86_32_common *x86_32 = calloc(1, sizeof(struct x86_32_common));
if (!x86_32) {
diff --git a/src/target/quark_x10xx.c b/src/target/quark_x10xx.c
index 0daa642b85..2abc32ab7b 100644
--- a/src/target/quark_x10xx.c
+++ b/src/target/quark_x10xx.c
@@ -40,7 +40,7 @@
#include "lakemont.h"
#include "x86_32_common.h"
-static int quark_x10xx_target_create(struct target *t, Jim_Interp *interp)
+static int quark_x10xx_target_create(struct target *t)
{
struct x86_32_common *x86_32 = calloc(1, sizeof(*x86_32));
diff --git a/src/target/riscv/riscv.c b/src/target/riscv/riscv.c
index 6a8577f5cb..11ef8f9b92 100644
--- a/src/target/riscv/riscv.c
+++ b/src/target/riscv/riscv.c
@@ -427,7 +427,7 @@ static struct target_type *get_target_type(struct target
*target)
}
}
-static int riscv_create_target(struct target *target, Jim_Interp *interp)
+static int riscv_create_target(struct target *target)
{
LOG_DEBUG("riscv_create_target()");
target->arch_info = calloc(1, sizeof(struct riscv_info));
diff --git a/src/target/stm8.c b/src/target/stm8.c
index 76482e8789..c80ea0eb20 100644
--- a/src/target/stm8.c
+++ b/src/target/stm8.c
@@ -1106,8 +1106,7 @@ static int stm8_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int stm8_target_create(struct target *target,
- Jim_Interp *interp)
+static int stm8_target_create(struct target *target)
{
struct stm8_common *stm8 = calloc(1, sizeof(struct stm8_common));
diff --git a/src/target/target.c b/src/target/target.c
index ea8f000c29..8ccab7e0ab 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -5858,7 +5858,7 @@ COMMAND_HANDLER(handle_target_create)
}
if (target->type->target_create) {
- retval = (*target->type->target_create)(target,
CMD_CTX->interp);
+ retval = (*target->type->target_create)(target);
if (retval != ERROR_OK) {
LOG_DEBUG("target_create failed");
free(target->cmd_name);
diff --git a/src/target/target_type.h b/src/target/target_type.h
index ce98cbad27..eddedbf34f 100644
--- a/src/target/target_type.h
+++ b/src/target/target_type.h
@@ -194,7 +194,7 @@ struct target_type {
const struct command_registration *commands;
/* called when target is created */
- int (*target_create)(struct target *target, Jim_Interp *interp);
+ int (*target_create)(struct target *target);
/* called for various config parameters */
/* returns JIM_CONTINUE - if option not understood */
diff --git a/src/target/xscale.c b/src/target/xscale.c
index 5cc790a311..84318a905f 100644
--- a/src/target/xscale.c
+++ b/src/target/xscale.c
@@ -3012,7 +3012,7 @@ static int xscale_init_arch_info(struct target *target,
return ERROR_OK;
}
-static int xscale_target_create(struct target *target, Jim_Interp *interp)
+static int xscale_target_create(struct target *target)
{
struct xscale_common *xscale;
diff --git a/src/target/xtensa/xtensa_chip.c b/src/target/xtensa/xtensa_chip.c
index ce6d35cabf..aab7ee37c5 100644
--- a/src/target/xtensa/xtensa_chip.c
+++ b/src/target/xtensa/xtensa_chip.c
@@ -81,7 +81,7 @@ static const struct xtensa_power_ops xtensa_chip_dm_pwr_ops =
{
.queue_reg_write = xtensa_dm_queue_pwr_reg_write
};
-static int xtensa_chip_target_create(struct target *target, Jim_Interp *interp)
+static int xtensa_chip_target_create(struct target *target)
{
struct xtensa_debug_module_config xtensa_chip_dm_cfg = {
.dbg_ops = &xtensa_chip_dm_dbg_ops,
--
