This is an automated email from Gerrit.

"Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>" just uploaded a new patch 
set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/8861

-- gerrit

commit 4a1e13279a19b3a915d4944916bdd6b6c573e6c7
Author: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>
Date:   Mon Apr 28 16:55:35 2025 +0300

    target: improve error reporting for `-event` option
    
    `target create` calls can get quite long and an indication what is the
    option that caused the error can be helpful.
    
    Also, there can be multiple `-event` options for different events,
    therefore indicating which one is it is also helpful.
    
    Change-Id: I5ea61437ca9705e790ed8343183883a3fdfebc80
    Signed-off-by: Evgeniy Naydanov <evgeniy.nayda...@syntacore.com>

diff --git a/src/target/target.c b/src/target/target.c
index 791da4b05e..1af36778e8 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4924,7 +4924,8 @@ static COMMAND_HELPER(target_configure, struct target 
*target, unsigned int inde
 
                case TCFG_EVENT:
                        if (index == CMD_ARGC) {
-                               command_print(CMD, "missing event-name");
+                               command_print(CMD, "expecting %s event-name 
event-body",
+                                               CMD_ARGV[index - 1]);
                                return ERROR_COMMAND_ARGUMENT_INVALID;
                        }
 
@@ -4937,7 +4938,8 @@ static COMMAND_HELPER(target_configure, struct target 
*target, unsigned int inde
 
                        if (is_configure) {
                                if (index == CMD_ARGC) {
-                                       command_print(CMD, "missing 
event-body");
+                                       command_print(CMD, "expecting %s %s 
event-body",
+                                                       CMD_ARGV[index - 2], 
CMD_ARGV[index - 1]);
                                        return ERROR_COMMAND_ARGUMENT_INVALID;
                                }
                        }

-- 

Reply via email to