This is an automated email from Gerrit.
"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9079
-- gerrit
commit dd983a8f8de02b79499e7464f4a5074d3a4d0a4e
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date: Tue Aug 12 15:32:51 2025 +0200
target: drop hint about using Tcl/Tk events
The pre-git commit ef1cfb23947b ("Duane Ellis: "target as an [tcl]
object" feature.") adds a FIXME comment about the possibility to
reuse Tcl/Tk events in OpenOCD.
The Tcl/Tk events are useful for User Interfaces (UI) as they are
triggered by window system events, e.g. by X11. See [1] and [2].
The events in OpenOCD have no link with any UI and are triggered
by the same OpenOCD code, which is quite far from Tcl/Tk events.
Probably, to avoid confusion with Tcl, we should even rename the
OpenOCD 'events' as 'callbacks' or similar.
Drop the misleading comment.
Change-Id: Iccb97db483804765866acdbf7c55adc6c5222674
Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
Link: http://www.tcl-lang.org/man/tcl8.6/TkCmd/event.htm [1]
Link: https://www.tcl-lang.org/man/tcl8.6/TkCmd/bind.htm [2]
diff --git a/src/target/target.c b/src/target/target.c
index 002fd78864..a6ad202d77 100644
--- a/src/target/target.c
+++ b/src/target/target.c
@@ -4985,16 +4985,6 @@ static COMMAND_HELPER(target_configure, struct target
*target, unsigned int inde
/* use jim object to keep its reference
on tcl file and line */
/* TODO: need duplicate? isn't
IncrRefCount enough? */
teap->body =
Jim_DuplicateObj(teap->interp, CMD_JIMTCL_ARGV[index++]);
- /*
- * FIXME:
- * Tcl/TK - "tk events" have a nice
feature.
- * See the "BIND" command.
- * We should support that here.
- * You can specify %X and %Y in the
event code.
- * The idea is: %T - target name.
- * The idea is: %N - target number
- * The idea is: %E - event name.
- */
Jim_IncrRefCount(teap->body);
if (!replace) {
--
