[PATCH]: 49a266612f drivers: ch347: fix scan-build warnings

[gerrit]

This is an automated email from Gerrit.

"Antonio Borneo <borneo.anto...@gmail.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9094

-- gerrit

commit 49a266612fa135c109eac7e97a52bcc661ea8237
Author: Antonio Borneo <borneo.anto...@gmail.com>
Date:   Sun Aug 24 12:30:52 2025 +0200

    drivers: ch347: fix scan-build warnings
    
    The newly merged driver ch347 triggers two new scan-build warnings
    about dead assignment to variables.
    
    Fix them.
    
    Change-Id: Ided14272c3573be1498584e68ac4653cde029f31
    Signed-off-by: Antonio Borneo <borneo.anto...@gmail.com>
    Fixes: 7d0e12589629 ("jtag/drivers: Add support for CH347-based JTAG 
adapters")

diff --git a/src/jtag/drivers/ch347.c b/src/jtag/drivers/ch347.c
index 8f563acafc..a0404a21fc 100644
--- a/src/jtag/drivers/ch347.c
+++ b/src/jtag/drivers/ch347.c
@@ -863,7 +863,6 @@ static int ch347_single_read_get_byte(int read_buf_idx, 
uint8_t *byte)
 
        if (read_buf_idx > CH347_SINGLE_CMD_MAX_READ || read_buf_idx < 0) {
                LOG_ERROR("read_buf_idx out of range");
-               read_buf_idx = 0;
                return ERROR_FAIL;
        }
 
@@ -989,7 +988,6 @@ static int ch347_scratchpad_add_stableclocks(int count)
        }
 
        bool tms = ch347.tms_pin == TMS_H;
-       retval = ERROR_OK;
        for (int i = 0; i < count; i++) {
                retval = ch347_scratchpad_add_clock_tms(tms);
                if (retval != ERROR_OK)

--