[PATCH]: 3bfdb4dedd jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend

[gerrit]

This is an automated email from Gerrit.

"Samuel Obuch <samuel.ob...@espressif.com>" just uploaded a new patch set to 
Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9115

-- gerrit

commit 3bfdb4deddf311395ba9dd931086c31d2af2f3c0
Author: Samuel Obuch <samuel.ob...@espressif.com>
Date:   Mon Sep 8 12:25:32 2025 +0200

    jtag/drivers/cmsis_dap: fix build with cmsis_dap_tcp backend
    
    For some hosts build fails after the recent cmsis_dap_tcp addition
    (see commit fcff4b712c53a6169f0f96dd63f0adb1b12a1789 or
    https://review.openocd.org/c/openocd/+/8973)
    
    - Header 'hidapi.h' may not be available and should not be needed here.
    
    - Global pointer variable is not guaranteed to be treated as a constant
      expression even with const modifier. Use global array instead, to avoid
      'error: initializer element is not constant', as address of a global
      array is a constant expression.
    
    Change-Id: I0c72ff52340f546a5f635663a8fde28c99176d1b
    Signed-off-by: Samuel Obuch <samuel.ob...@espressif.com>

diff --git a/src/jtag/drivers/cmsis_dap_tcp.c b/src/jtag/drivers/cmsis_dap_tcp.c
index a654c6bffd..8a96cd6244 100644
--- a/src/jtag/drivers/cmsis_dap_tcp.c
+++ b/src/jtag/drivers/cmsis_dap_tcp.c
@@ -20,7 +20,6 @@
 #include "config.h"
 #endif
 
-#include <hidapi.h>
 #ifdef HAVE_NETDB_H
 #include <netdb.h>
 #endif
@@ -90,7 +89,7 @@ struct cmsis_dap_backend_data {
 };
 
 static char *cmsis_dap_tcp_host;
-static char *const cmsis_dap_tcp_port_default = STRINGIFY(CMSIS_DAP_TCP_PORT);
+static char cmsis_dap_tcp_port_default[] = STRINGIFY(CMSIS_DAP_TCP_PORT);
 static char *cmsis_dap_tcp_port = cmsis_dap_tcp_port_default;
 static int cmsis_dap_tcp_min_timeout_ms = DEFAULT_MIN_TIMEOUT_MS;
 

--