This is an automated email from Gerrit. "zapb <[email protected]>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9661
-- gerrit commit b4ecae8d724057daf116042c2ea0d47df4b85ea4 Author: Marc Schink <[email protected]> Date: Fri May 15 13:15:14 2026 +0200 adapter/cmsis-dap: Remove redundant NULL check in LOG_ERROR() Drop the conditional around cmsis_dap_tcp_host in LOG_ERROR(), since the variable is already checked earlier and cannot be NULL at this point. Change-Id: I3971d4fe624c0b4eb6164a0eb6d435407b2371ad Signed-off-by: Marc Schink <[email protected]> diff --git a/src/jtag/drivers/cmsis_dap_tcp.c b/src/jtag/drivers/cmsis_dap_tcp.c index 6efd6b5d1f..124c774209 100644 --- a/src/jtag/drivers/cmsis_dap_tcp.c +++ b/src/jtag/drivers/cmsis_dap_tcp.c @@ -139,8 +139,7 @@ static int cmsis_dap_tcp_open(struct cmsis_dap *dap, int fd = 0; LOG_INFO("CMSIS-DAP: Connecting to %s:%s using TCP backend", - cmsis_dap_tcp_host ? cmsis_dap_tcp_host : "localhost", - cmsis_dap_tcp_port); + cmsis_dap_tcp_host, cmsis_dap_tcp_port); /* Some of the following code was taken from remote_bitbang.c */ /* Obtain address(es) matching host/port */ @@ -174,8 +173,7 @@ static int cmsis_dap_tcp_open(struct cmsis_dap *dap, if (!rp) { /* No address succeeded */ LOG_ERROR("CMSIS-DAP: unable to connect to device %s:%s", - cmsis_dap_tcp_host ? cmsis_dap_tcp_host : "localhost", - cmsis_dap_tcp_port); + cmsis_dap_tcp_host, cmsis_dap_tcp_port); log_socket_error("Failed to connect"); free(dap->bdata); dap->bdata = NULL; --
