This is an automated email from Gerrit. "Antonio Borneo <[email protected]>" just uploaded a new patch set to Gerrit, which you can find at https://review.openocd.org/c/openocd/+/9740
-- gerrit commit f3a895686e7534e42b1f42d1dfeea83b949f22de Author: Antonio Borneo <[email protected]> Date: Thu Jun 11 17:58:11 2026 +0200 jtag: check tap_state_by_name() return value against TAP_INVALID The return value of tap_state_by_name() is an enum tap_state. Don't compare it with zero to check if it's not valid but use the enum's value TAP_INVALID. Change-Id: I185a86a71f6ddbd4e28aca329552dfb94aee5b57 Signed-off-by: Antonio Borneo <[email protected]> diff --git a/src/jtag/tcl.c b/src/jtag/tcl.c index 90d6799abc..96066c5afa 100644 --- a/src/jtag/tcl.c +++ b/src/jtag/tcl.c @@ -130,7 +130,7 @@ COMMAND_HANDLER(handle_jtag_command_drscan) if (CMD_ARGC > 3 && !strcmp("-endstate", CMD_ARGV[CMD_ARGC - 2])) { const char *state_name = CMD_ARGV[CMD_ARGC - 1]; endstate = tap_state_by_name(state_name); - if (endstate < 0) { + if (endstate == TAP_INVALID) { command_print(CMD, "endstate: %s invalid", state_name); return ERROR_COMMAND_ARGUMENT_INVALID; } @@ -183,7 +183,7 @@ COMMAND_HANDLER(handle_jtag_command_pathmove) for (unsigned int i = 0; i < CMD_ARGC; i++) { states[i] = tap_state_by_name(CMD_ARGV[i]); - if (states[i] < 0) { + if (states[i] == TAP_INVALID) { command_print(CMD, "endstate: %s invalid", CMD_ARGV[i]); return ERROR_COMMAND_ARGUMENT_INVALID; } --
