> >>This allows for implementing the target event scripts in Tcl.
> >
> > I have looked into this, and as far as my debugging goes it 
> makes no 
> > difference command_run_line gets called whatever interface is used.
> 
> So from this I understand that you do not mind support for 
> target event proc's in Tcl.
> 

Not at all.

> > A few other things i have noticed:
> >
> > 1. The user output is a bit messed up aswell.
> > Try running a reset script calling flash info 0 to see what i mean.
> >
> > 2. I have also changed the command_run_line behaviour it 
> was searching 
> > each openocd command twice.
> 
> Changes to command.* look fine to me.
> 

I have committed.

> >
> > Find attached a patch for review that makes a few changes 
> with no loss 
> > of tcl capability - as far as my tests go.
> 
> You pulled out the capability to write Tcl proc's for target events.
> 
> Was that intentional?
> 

I do not see how, tcl is still working in a reset script for me.
all tcl does is create a proc that calls "openocd script reset.script" for
example.
everything leads to command_run_line in the end, so if openocd does not
handle it tcl will.

tested with a simple func in the reset script, eg.
proc tcl_test {} {echo "Production test not implemented"}

i have noticed that neither my patched version or svn head do not handle
multiple line procs
in event script, so my patch has no impact on current svn head.

Cheers
Spen

_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to