On Tue, Jul 29, 2008 at 5:59 PM, Spen <[EMAIL PROTECTED]> wrote: > Hi, > > Find attached a patch for review that adds support for rle packets to gdb > support.
I'd say that rle compression will slow things down, not speed them up. > This simply reduces repeated chars when sent from openocd - register packet > and > memory reads generally will increase in speed as the packet len is reduced. Why is this an advantage? > I have also changed gdb_put_packet_inner to use a shared buffer, we should > never get any packet bigger than GDB_BUFFER_SIZE. > > if everyone is happy i will commit. I'd want to see some measurements showing that this is an improvement. It's a performance regression for embedded hosts as it currently stands. The current code for sending data from the gdb_server to GDB has been optimized for the common code path, so you'll find that it is harder to beat than you might think. Also, the patch replaces tested code... The ack, checksum and escape char-less protocol would improve things I think(you mentioned some work in progress over on the gdb development mailing list). -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 XScale Cortex JTAG debugger and flash programmer _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
