Hi, > - Add the new interface type and its options to the documentation > (doc/openocd.texi) added. > - Don't use _DEBUG_USB_COMMS_ and _DEBUG_JTAG_IO_. LOG_DEBUG ensures that > they are only output if someone uses 'debug_level 3'. I'd rather get all the > debug info than > dig around trying to find the #define that I need to enable. In my opinion, '-d3' is used when debugging OpenOCD. But there is no debug_level to use when debugging JTAG tools. These 2 commands are similar to those in jlink driver. > - Break the 'vsllink_usb' command into a few subcommands: vid, pid, bulkout, > bulkin. That way the line in the config isn't so cryptic. modified. > - The following LOG_INFO line in vsllink_init should probably have some > explanation rather than just dumping what is in the usb input buffer: > LOG_INFO(VSLLINK_usb_in_buffer + 2); > It also generates a compiler warning due to the buffer being unsigned. > - Compiler warning for the usb_bulk_write() in vsllink_usb_write(): > vsllink.c:1242: warning: pointer targets in passing argument 3 of > �usb_bulk_write?differ in signedness > - Compiler warning for the usb_bulk_read() in vsllink_usb_read(): > vsllink.c:1262: warning: pointer targets in passing argument 3 of > �usb_bulk_read?differ in signedness modified.
Attachment is the new patch. vsllink driver is originally developped based on the struct of jlink driver and usbprog driver, should I add these information? Protocols of vsllink is totally different from jlink and usbprog, so it will not break any license. 2008-12-25 Best Regards, Simon Qian SimonQian([email protected]) ---- www.SimonQian.com
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
