On Feb 10, 2009, at 8:24 AM, Dick Hollenbeck wrote:
Rick Altherr wrote:On Feb 10, 2009, at 3:16 AM, Luke Dunstan wrote:Hi, On Linux:gcc -DHAVE_CONFIG_H -I. -I../.. -I../../src -I../../src/helper - I../../src/target -g -O0 -I/home/infidel/prefix/include -Wall - Wstrict-prototypes -MT jtag.o -MD -MP -MF .deps/jtag.Tpo -c -o jtag.o jtag.cjtag.c: In function ‘jtag_add_pathmove’: jtag.c:960: error: ‘TRUE’ undeclared (first use in this function) jtag.c:960: error: (Each undeclared identifier is reported only once jtag.c:960: error: for each function it appears in.) jtag.c:961: error: ‘FALSE’ undeclared (first use in this function)It will be necessary to conditionally define BOOL, TRUE and FALSE, perhaps with #ifndef _WIN32 or #ifndef TRUE.Regards, Luke _______________________________________________ Openocd-development mailing list[email protected] <mailto:[email protected] >https://lists.berlios.de/mailman/listinfo/openocd-developmentLooks like 2 cases were missed in r1368. r1369 should work now.No, r1369 is crap.Please put back the TRUE and FALSE usages, and then conditionally define them as Luke suggested.BOOL is a useful datatype in C. We are not writing this code solely for the benefit of the compiler, the human enters into it also.Dick
BOOL isn't defined in C. bool exists in C99 if you include <stdbool.h>. My interest was in getting the build working again, not making it pretty. If you want to use BOOL, make a patch that introduces the type correctly. I'm also OK with using stdbool.h as it is a standard.
-- Rick Altherr [email protected]"He said he hadn't had a byte in three days. I had a short, so I split it with him."
-- Unsigned
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
