Hi all,

I like to use -Wall -Wextra -Werror when building, so I have attached
two patches that fix warnings when using -Wextra.  The patch for etm.c
removes a condition that is always true, and the patch for jtag.c fixes
the order of C keywords.  Apply either or both.  There will be more, but
these are getting in my way at the moment.

Cheers,

Zach

diff -u src/target/etm.c src/target/etm.c
--- src/target/etm.c	(working copy)
+++ src/target/etm.c	(working copy)
@@ -883,7 +883,7 @@
 				continue;
 
 			/* indirect branch to the exception vector means an exception occured */
-			if (((ctx->last_branch >= 0x0) && (ctx->last_branch <= 0x20))
+			if ((ctx->last_branch <= 0x20)
 				|| ((ctx->last_branch >= 0xffff0000) && (ctx->last_branch <= 0xffff0020)))
 			{
 				if ((ctx->last_branch & 0xff) == 0x10)
diff -u src/jtag/jtag.c src/jtag/jtag.c
--- src/jtag/jtag.c	(working copy)
+++ src/jtag/jtag.c	(working copy)
@@ -3089,7 +3089,7 @@
 	 *
 	 * DRSHIFT->DRSHIFT and IRSHIFT->IRSHIFT have to be caught in interface specific code
 	 */
-	const static u8 tms_seqs[6][6] =
+	static const u8 tms_seqs[6][6] =
 	{
 		/* value clocked to TMS to move from one of six stable states to another */
 
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to