On Tue, Apr 28, 2009 at 8:23 AM, Øyvind Harboe <[email protected]> wrote: > Do we really want to go down the path of macros?
Yes. The ifs obscure the actual algorithm by turning a short one-line function call into five lines of (dense) operator soup with the actual action lost somewhere in between. > There are two audiences for this code: > > - those that work on the code all the time > - the casual reader/debugger > > For the second group, the code is not less readable. I disagree. Unless what you are trying to read is the syntactic sugar rather than the actual algorithm. > The ARM11 code has a lot of strange microconstructs that I have to decode > when I take on the hat of the second group.... If CHECK_RETVAL isn't clear enough, feel free to suggest a better name. Michael _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
