Raúl Sánchez Siles wrote:
> Hello all:
>
> This start a patchset series for implementing x16_as_x8 cfi compliant
> feature.
>
> · 01-x16_as_x8-consolidate_addresses.patch
> · 02-x16_as_x8-flash_address.patch
> · 03-x16_as_x8-multibyte_read.patch
>
> I have taken a view to the CFI specification [0] and it looks that the
> approach should also work for intel chips, while I had only tested it with
> spansion flash.
>
That looks good to me - I would have expected a lot more changes.
Some style comments:
- I do not really like left shifts with what is effectively a bool
variable as shift amount ("bank->bus_width << cfi_info->x16_as_x8"). The
logic is correct, but it looks strange.
- In cfi.c, I think we should always use a loop of single-byte reads
instead of using separate code for the x16_as_x8 and the "normal" case.
Using the single-byte reads should be safe on wider bus/flash widths,
and would make one code path that is better tested.
cu
Michael
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
