> assert() simply does not seem correct for this kind of check; you are > not checking for programming errors. These checks are for potential > run-time errors -- particularly now that you have added a Jim command to > call this function directly.
Read my patch carefully: the assert() only runs *AFTER* the check has happened. Why? jtag_add_pathmove() is the one that does all sanity check runtime and reports an error. No exit() upon user error here. jtag_add_pathmove_nocheck() is the to-the-metal version that is used in code that *does not* have any user input arguments and where the code *will* pass in correct arguments, e.g. inside xscale.c. -- Øyvind Harboe Embedded software and hardware consulting services http://consulting.zylin.com _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
