On Tue, 2009-06-30 at 20:42 -0400, Duane Ellis wrote: > [email protected] wrote: > > Author: zwelch > > Date: 2009-07-01 00:25:09 +0200 (Wed, 01 Jul 2009) > > New Revision: 2438 > > > > Modified: > > trunk/src/flash/flash.c > > Log: > > Remove at91sam3.h from flash.c; use extern like other drivers. > > > > > > If you are doing this then you should remove the file "at91sam3.h" also > - all it contains is the 'extern' nothing else. > The *only* public symbol is - by design - the structure.
FWIW, the simple 'extern' declarations will become obsolete when we convert to allowing both static and loadable modules. However, I would rather see you move some of the things in the C file into the H file (all of the #defines and struct declarations, to start). Basically, use it as the driver's private header file. Thanks, Zach _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
