On Wed, 2009-07-08 at 01:02 -0400, Nicolas Pitre wrote:
> Before, the ./configure --help used to list --enable-parport-ppdev
> instead of the current --disable-parport-ppdev. The later suggests that
> parport-ppdev is now set by default when using --enable-parport (which
> would be a good thing I think) but this is apparently not the case.
Since I changed that text, I clearly meant for it to be enabled by
default on x86; it always gets set on other hosts. When I factored that
configure code, I also changed the help text. I thought that I got the
logic right, but I just verified it to see if it was correct. It's not.
The attached patch ensures this feature has been enabled when the user
does not pass either option to the configure script. This may force
some developers to add --disable-parport-ppdev, though I am not sure
which platform(s) will require that.
If others will ACK this, I can shove it into the trunk for 0.2.0. This
seems like it could be a regression that I caused, and the fix appears
easy and obvious.
Cheers,
Zach
Index: configure.in
===================================================================
--- configure.in (revision 2513)
+++ configure.in (working copy)
@@ -308,7 +308,7 @@
AC_ARG_ENABLE(parport_ppdev,
AS_HELP_STRING([--disable-parport-ppdev],
[Disable use of ppdev (/dev/parportN) for parport (for x86 only)]),
- [parport_use_ppdev=$enableval], [parport_use_ppdev=])
+ [parport_use_ppdev=$enableval], [parport_use_ppdev=yes])
AC_ARG_ENABLE(parport_giveio,
AS_HELP_STRING([--enable-parport-giveio],
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
