Hi, On Wed, Aug 26, 2009 at 17:58, David Brownell<[email protected]> wrote: > On Wednesday 26 August 2009, Igor Skochinsky wrote: >> As for ARM, I think arm_simulator.c and arm_disassembler.c should be >> merged since they share a lot of functionality. > > They seem kind of separate to me. I can disassemble without > wanting to simulate. And vice versa. > > If anything, they should be *more* separate.
Sorry, I did not look closely at the code. I saw some bit manipulation and mistakenly thought that simulator does it to determine the instruction type, operands etc. Now I see that it uses disassembler to parse the instruction, and that's what I meant about "merging" them. There's no need to actually merge the files, I only wanted to avoid code duplication. > The whole simulator bears some thought though. Is the whole > point of it just to enable one type of single stepping? I > don't recall seeing comments about when/why the simulator > would kick in. Right now it seems to be used only for single-stepping. I'm not sure if there are any other uses. -- WBR, Igor _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
