Re: [Openocd-development] Remove bogus "BUG:" in error messages

[Zach Welch]

I think that these two blocks of code need to be put in a static helper
that eliminates their duplicated functionality.

On Wed, 2009-08-26 at 12:03 +0200, Øyvind Harboe wrote:
> If the PC is pointing to an invalid instruction, then simulation will
> fail. This is
> expected.
> 
> ### Eclipse Workspace Patch 1.0
> #P openocd
> Index: src/target/arm7_9_common.c
> ===================================================================
> --- src/target/arm7_9_common.c        (revision 2625)
> +++ src/target/arm7_9_common.c        (working copy)
> @@ -1833,7 +1833,7 @@
>                       {
>                               uint32_t current_opcode;
>                               target_read_u32(target, current_pc, 
> &current_opcode);
> -                             LOG_ERROR("BUG: couldn't calculate PC of next 
> instruction,
> current opcode was 0x%8.8" PRIx32 "", current_opcode);
> +                             LOG_ERROR("Couldn't calculate PC of next 
> instruction, current
> opcode was 0x%8.8" PRIx32 "", current_opcode);
>                               return retval;
>                       }
> 
> @@ -2038,7 +2038,7 @@
>       {
>               uint32_t current_opcode;
>               target_read_u32(target, current_pc, &current_opcode);
> -             LOG_ERROR("BUG: couldn't calculate PC of next instruction, 
> current
> opcode was 0x%8.8" PRIx32 "", current_opcode);
> +             LOG_ERROR("Couldn't calculate PC of next instruction, current
> opcode was 0x%8.8" PRIx32 "", current_opcode);
>               return retval;
>       }
> 
> 
> 

_______________________________________________
Openocd-development mailing list
Openocd-development@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/openocd-development