Steve,
Thanks for the code review. Re this one:
On Monday 24 August 2009, Steve Grubb wrote:
> In src/flash/davinci_nand.c at line 648 we find this code:
>
> chip = strtoul(argv[2], &ep, 0);
> if (*ep || chip == 0 || chip == ULONG_MAX) {
> LOG_ERROR("Invalid NAND chip address %s", argv[2]);
> goto fail;
>
> Then at line 665 we find this:
>
> aemif = strtoul(argv[4], &ep, 0);
> if (*ep || chip == 0 || chip == ULONG_MAX) {
> LOG_ERROR("Invalid AEMIF controller address %s", argv[4]);
> goto fail;
>
> Its checking chip again. Is that a copy and paste mistake?
Yes. Patch forthcoming.
- Dave
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
