On Tuesday 29 September 2009, simon qian wrote: > OUTPUT doesn't conflict with system header files.
I checked in a fix. > But I recommend to use MODULE_XXXXX to define a macro, > so it will never conflict with anything. > After all, IN, OUT, OUTPUT, INPUT and COUNTER are > commonly used. The real bug here is that the MinGW system headers (or is it Win32?) chose to pollute global namespaces. The general policy is that *system* code should be clearly split out from application code, using such name prefixes. A name like "OUT" doesn't look even vaguely system-specific ... a classic app-space name. Another general policy is that system headers should not pull in unrelated crap. Like, say, DCE ... which isn't even used by OpenOCD. Yeah, I know it's unrealistic to expect standard coding discipline from the Win32 system headers. But it's fair to point out the root causes of bugs. ;) - Dave _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
