On Wed, 2009-10-28 at 11:18 -0700, David Brownell wrote: > FYI, I've committed some patches removing needless > > - function exports, when nothing outside the file > uses those functions; and > > - forward declarations, sometimes reordering code > > The affected files were Cortex-M3 and ARM926. > > Not marking code (or data) static is sloppy, and hides > true interface boundaries. Plus, it prevents compilers > from optimizing some things, hides stuff that's really, > and makes code needlessly hard to understand (because > of that interface boundary issue). Heck, it even makes > linking be more expensive (more symbols to crunch). > > And forward declarations should only really be used > when they're unavoidable ... they clutter the code. > > Let me know if you really want to see such patches > come by on the mailing list, and I'll do that too; > but my preference is to reduce the noise involved > with such *pure cleanup* patches. Changes affecting > code flow are what deserve the more-eyes benefits.
Is this for 0.3.0 or 0.4.0? I have ~50 patches and at least one or two will probably have minor conflicts with yours. I also am looking at doing a ton more cleanup like the stuff you have done, but I am waiting until a) we ship 0.3.0 and b) I get my current series in the tree. If I had continued, I'd probably have a stack of at least 200 by now, so there is no question about the opportunities to do this kind of work. The question is when we should merge them. --Z _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
