On Wednesday 28 October 2009, FangfangLi wrote:
> Dear Sir:
>
> for the bellow statement:
> SDR 3 TDI (5) TDO (2);
That's sneaky ... including a test report with a bug report!
> In function :svf_copy_hexstring_to_binary
> // check valid
> if (str_len > 0 || (ch & ~((1 << (4 - (bit_len % 4))) - 1)) != 0)
>
> It report : LOG_ERROR("value execede length");
> But in fact , it is not.
That code is quite cryptic, yes. You can't exactly look
at it and understand what it's trying to do without first
staring at it for a while. :)
That seems to be from afae28fb2cfaa2da08311e9d17bf9c8057a2f399
(no one-line summary) in August. It's from Piotr, who I cc'd,
and was intended to make Altera Quatrus II 9.0 output work
better with OpenOCD.
> I try to modify to as bellow, It can pass the parser check now.
>
> if (str_len > 0 || (ch && (bit_len%4) && (ch >= (1<< (bit_len%4)))))
>
>
> You can check if it is one real bug, and go to fix it if need.
I've added a few CC's to your bug report. Maybe someone
who'd deeper into SVF syntax/parsing than I am can come
up with a solid patch.
Thanks for the bug report!
- Dave
>
> Thanks,
> FFLI
> --
> Best regards,
> FFLi
> ===============================================
> Fangfang Li
> Regional Manager
> SynTest Technologies (Shanghai), Inc.
> Rm. 8501, Pudong Software Park
> 498 Guoshoujing Rd.
> Shanghai 201200, P.R.China,
> 86-21-5027-2068 x 107(TEL); 86-21-5027-2070(FAX)
> [email protected]; http://www.syntest.com.cn
>
> "SynTest: Design Confidence Through Innovation"
> ================================================
>
>
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
