On Fri, 30 Oct 2009, David Brownell wrote:

> On Friday 30 October 2009, Nicolas Pitre wrote:
> > I really don't like this pointer business.  No type checking at all, 
> > etc.  This should be turned upside down as you suggested already: embed 
> > more generic structures within the more specific ones, and copy the 
> > container_of() macro from Linux to get at the outer structure when 
> > needed.
> 
> I was working on such patches when I noticed this goof ...
> 
>       arm926ejs = target_to_arm926(target);
> 
> without all that other crap is a *LOT* cleaner IMO.  Very
> few of the functions need pointers to the "inner" structs;
> that idiom just makes things confusing.

Goodie!

> However, such changes would be wrong to merge before we
> finally let 0.3.x out the door.

No question about that.


Nicolas
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to