On Tue, 2009-11-17 at 18:43 +0100, Øyvind Harboe wrote: > On Tue, Nov 17, 2009 at 6:39 PM, Zachary T Welch <[email protected]> > wrote: > > Hi all, > > > > This series modularizes the startup.tcl file, putting various pieces > > of the system where they belong. Instead of linking it into the library, > > provide it as a parameter to the command_init() routine from openocd.c. > > Fixes the layering violations that this built-in TCL code created. > > Back in the mists of time startup.tcl was embedded into openocd because > that made it possible to use *only* the openocd executable + a monolithic > script to configure a target and do a particular task.
I still like allowing for embedded script, as it keeps alive the vague possibility of running OpenOCD on embedded platforms where file storage is a luxury. That probably will not happen for 1.0 though. ;) > Perhaps we should no longer embed startup.tcl but install it instead? That's another problem, but one suitable for this series. The answer to the question above determines whether we want such a patch. More work could be done in this area, but the existing series solves the immediate layering problem. Whether the policy changes from passing in as-is or installed and read as a file, the current changes will still be useful and relevant. I would suggest the split startup files (created by patch 2/3) be renamed as "tcl/startup/<module>.tcl", and they will install with the rest of that tree. The required patch should be fairly trivial. --Z _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
