On Wed, Nov 18, 2009 at 9:38 AM, Laurent Gauch <[email protected]> wrote: >> >> I'm pondering how we could gently in a series of >> non-breaking patches prepare the ground for switching from >> 8 to 32 bit words in the jtag_add_xxx API. >> >> The attached patch gets rid of buf_set_u32() when setting >> the value of a byte. >> >> This achieves two things: the code is less obtuse and it >> is more evident how we could introduce a new type >> that is *currently* uint8_t and later on could be increased to >> uint32_t or wider, for the out_value/in_value bit vectors. >> >> Comments? Protests? > > JTAG serial link itself has a notion of bits and not bytes nor dwords ... > > I do not understand what is the advantage to work on 32bit buffers > instead 8bit buffers for out_value and in_value. > Why the code will be less obtuse use 32bit buffer instead 8 bit buffers ?
Look at all the buf_set_u32()'s sprinkled around the code. They are essentially unnecessary. The drivers probably wouldn't change. -- Øyvind Harboe http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
