On Tue, 2009-11-24 at 21:36 +0100, Øyvind Harboe wrote:
> On Tue, Nov 24, 2009 at 9:34 PM, Zach Welch <[email protected]> wrote:
> > On Tue, 2009-11-24 at 20:52 +0100, Øyvind Harboe wrote:
> >> I'll push this if I don't hear anything.
> >>
> >> The code adheres to these rules at this point pretty much.
> >> There are a few sites that could be a bit better, but I don't
> >> fear that there are plentiful of bad examples that are
> >> copied and pasted.
> >
> > You're using terminology incorrectly, as a dynamic arrays include those
> > created by malloc().  I think you intend to add the following rule
> > (unless I've screwed it up too):
> >
> > - Use malloc to create dynamic arrays; do @b not use @c alloca() or
> > create variable-length arrays on the stack.
> 
> Good point.
> 
> >
> > Also, I do not like the idea of adding a new section for embedded hosts
> > with only one item in it.  I think the subject of "Embeddeding Open"
> > needs to be addressed more comprehensively in its own section.  There
> > are numerous issues that deserve to be documented, and the Style Guide
> > is not the right place to address any of these concerns directly.
> 
> Where then?

Technically, that feature is part of C99, so that section is fine for
the above rule.  For pages discussing embedded topics, I would start a
new doc/manual/embedded.txt file with pages for various embedded
concerns (e.g. implementation considerations, eCos issues, etc.).

--Z
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to