On Wed, 2009-11-25 at 08:00 +0100, EG wrote:
> Hello,
> please find a tar attached containing additional files and a diff to
> add flash support for the ADUC706x controller to openocd 0.3.1 ...
> Best regards, Enrico
Enrico,
Some initial feedback:
1. Please send only plain text attachments or in-line (no
tarballs). See the BUGS and PATCHES files for more information
about the best means of submitting patches. Learn to use 'git
format-patch' and 'git send-email', if you have them.
2. The code you have submitted will not build against the master
branch of the Git repository. There have been significant
changes to the tree since 0.3.1; however, they only should
affect your code superficially (e.g. no more struct typedefs).
3. Please take a moment to check out the Git repository and make
the changes required for your driver to compile and use current
style. If you don't want to work on this code anymore, that's
fine too. Just let us know what you're going to do, if we need
to pick it up.
4. After the above issues, I can take another serious look at the
code.
We'll look forward to seeing your revisions, but I am curious if you
have any broader insight to share about the flash layer after having
developed your new driver. What could be improved?
Cheers,
Zach
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
