On Thu, 3 Dec 2009, Zach Welch wrote: > On Thu, 2009-12-03 at 12:27 -0500, Nicolas Pitre wrote: > > On Thu, 3 Dec 2009, Zach Welch wrote: > > > > > On Thu, 2009-12-03 at 10:39 +0100, Øyvind Harboe wrote: > > > > I added a missing #include <sys/stat.h>, but it is not quite ready to > > > > commit > > > > yet I think. > > > > > > > > Does it build under Windows? Perhaps it does, I didn't try. > > > > > > > > I don't think we should try to make this work under anything but POSIX > > > > API for now, but the build should not fail. Autotools magic? > > > > > > > > Some docs to openocd.texi would be great. > > > > > > Okay, one more nit to pick from me too: use a static function to > > > encapsulate the hunk of new code that's being added 4-tabs to the wind. > > > Please, I beg you.... :) > > > > I know... My problem initially is that I had 3 cases: return error > > right away, return success right away, or fall through the code that > > follows. This was akward to express with a single return value so I > > just left the code inline and didn't revisit it. > > Feel free to submit additional patches to clean up the surrounding code > before your existing patch, if that will make the current patch cleaner. > The fact that there are already 3 levels of indent in that function > indicates such work would only improve the surrounding code. ;)
Please don't commit anything yet. I'm coming up with another version Nicolas
_______________________________________________ Openocd-development mailing list Openocd-development@lists.berlios.de https://lists.berlios.de/mailman/listinfo/openocd-development
