On Wed, Dec 16, 2009 at 9:00 PM, Carsten Breuer <[email protected]> wrote: > Hi Øyvind, > > >>> The first thing i had to learn was, that it is verry uncommon in >>> OpenOCD to check the result of malloc. >> This is a known problem where we gladly accept patches to fix each >> case. > > OK, then i will start to fix all the mallocs > that are handled not correct yet and where > i understand what to do if they fail.
Great! I think if you do a pass on the *simple* cases and just mark w/todo on the remaining ones that would be *great*. I think it makes sense to split this into many commits. Minimally one per file. I take it you are familiar with how to create a patch series? >> You will see by digging into the mailing list that we, the >> maintainers, are always very interested in cleaning up the code and >> that we gladly accept patches. > > Fine, that's good to hear. > I don't want to spend a lot of hours directly for /dev/null ;-). Focus on a handful of malloc()'s just ot get the procedure right w.r.t. committing to git, submitting patches, etc. >> There may be some of these cases that are a matter of opinion or >> taste, but generally following lint warnings/notes is a good idea. > > Ok. I know that some stuff can "taste not so good". > So I only change things that i classify as important. Start with the obviously broken and move down the list... -- Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
