On Friday 01 January 2010, Dean Glazeski wrote:
> Yep, it's a memory leak.  I suppose I was a bit hasty on posting it.  Here's
> a new version that also checks the success or failure of the alloc_printf
> functions.  I'm trying to think of a good way to determine if no matches are
> found for the given match string.  I'm not sure if anyone has a good idea
> for that since the functions being used are part of a double function
> recursion scheme.

This seems somewhat better.  I merged it, with a few tweaks;
if it needs more fix up, or even reversion for a better fix,
so be it.


> On another note, I was wondering if removing the error message from the
> group type in helper/startup.tcl in ocd_bouncer is a reasonable idea.  It
> looks a heck of a lot better to not have all of that error output when some
> one uses a group command without giving a subcommand.

There are at least two problems I still see with the "help" logic:

 - "flash addddddddddr" complains not about no such subcommand,
   but about a craving for more arguments.

 - "help flash" doesn't display the "flash bank" command, just
   the "flash banks".

Still, this seems like progress.

- Dave

_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to