>>>>> "David" == David Brownell <[email protected]> writes:

Hi,

 >>  doc/openocd.texi                        |    3 ++-
 >>  src/flash/nand/Makefile.am              |    1 +
 >>  src/flash/nand/driver.c                 |    2 ++
 >>  src/flash/nand/{s3c2443.c => s3c6400.c} |   28 ++++++++++++----------------

 David> Did you really intend to remove the s3c2443 driver?

No, it's a copy (diff -C) - E.G. from the part you quoted just below:

 >>  4 files changed, 17 insertions(+), 17 deletions(-)
 >>  copy src/flash/nand/{s3c2443.c => s3c6400.c} (81%)

 David> If it's as similar as you say, I'd suggest just adding
 David> hardware-specific state (and code) to handle the difference
 David> ... that is, keep reusing the same core code.

The 24xx stuff has lots of redundant code as is (E.G. s3c2412.c /
s3c2443.c are identical except for string, ..). I can refactor that, but
I don't have access to any 24xx boards to test.

-- 
Bye, Peter Korsgaard
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to